Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reset): Add cycle detection fix #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Oct 31, 2024

Here docker/compose#12247 (comment) the user found one more case when it fires while it shouldn't.

  1. Decided to move the detector inside the alias condition, because that's the only place where the cycle can happen.
  2. Added one more test

Signed-off-by: Suleiman Dibirov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant